Updating priors

Make core.prior completely independent of all gw.prior, continuing from https://git.ligo.org/Monash/tupak/merge_requests/56.

• Remove the GW specific default latex labels from core, this method can be overwritten in gw.
• Move the binary_black_holes.prior from core to gw?
• Have an empty PriorSet.test_redundancy which just does nothing which can be overwritten by whichever prior set you like, this will naturally be done by defining a subclass of PriorSet in gw/prior.py.
• Make create_default_prior require the second argument.
• Move everything currently in core/prior_files to gw/prior_files (or something similar). We'd also need to fix the setup.py file to see this, but its all gw-specific.

marked the checklist item Move the binary_black_holes.prior from core to gw? as completed

marked the checklist item Have an empty PriorSet.test_redundancy which just does nothing which can be overwritten by whichever prior set you like, this will naturally be done by defining a subclass of PriorSet in gw/prior.py. as completed

marked the checklist item Make create_default_prior require the second argument. as completed

marked the checklist item Make create_default_prior require the second argument. as incomplete

added 3 commits

• e87445a0 - remove default prior file from defult priors
• 700d941a - make prior file reading avoid comments
• d3c90300 - make prior tests run again

Compare with previous version

marked the checklist item Make create_default_prior require the second argument. as completed

marked the checklist item Move everything currently in core/prior_files to gw/prior_files (or something similar). We'd also need to fix the setup.py file to see this, but its all gw-specific. as completed

added 10 commits

• 226b6b64 - fix uniform in comoving volume prior file finding
• eadf5fad - use PriorSet rescaling function
• 3900958e - add probablility functions to PriorSet
• de1ff726 - add prob and ln_prob methods to Prior
• cd035a83 - update some utilities
• 474576c4 - clean up docstring
• 1b89c9a6 - fix sampling from prior
• 2f6cd610 - fix priorset probability functions
• 4676f70f - make sure Sampler.priors is a PriorSet
• f3ab1477 - reformatting

Compare with previous version

I've additionally made changes to sampler.py to make use of the PriorSet object.

added 3 commits

• 95bdf317 - remove old class, make tests run
• cd8c506b - fix UniformComovingVolume
• ae472456 - fix UniformComovingVolume

Compare with previous version

added 7 commits

• 9db4c495 - fix logic about prior type
• 87dcdede - make BBHPriorSet update test_redundancy
• cb41b057 - comment out superfluous parameters
• c7d67989 - fix redundancy logic
• d79f8438 - update docstring
• 6f13174f - update examples to use PriorSet
• 134f38a4 - update logic in prior filling

Compare with previous version

added 1 commit

• b057cb1d - use datetime for time manipulation, add evaluation time to sampler

Compare with previous version

marked the checklist item Remove the GW specific default latex labels from core, this method can be overwritten in gw. as completed

added 4 commits

• 05bd9620 - update example on specifying the prior
• 4e56722c - move default latex labels out of core
• 458bea2b - update minimal 150914 example
• 295e9424 - typo fix

Compare with previous version

This now does everything on the list and a couple of other small changes. @gregory.ashton do you want to look over it before merging?

unmarked as a Work In Progress

added 1 commit

• 65aa16b0 - update prior in 150914 example

Compare with previous version

Looks good to me :D

mentioned in commit e8cf8c0c

merged