Skip to content
Snippets Groups Projects

Updated CI to expose a bug in bilby_result for python2.7, then fixed it

Merged Duncan Macleod requested to merge duncanmmacleod/bilby:py27-keyword-attribute into master

This MR updates the CI to run a few more basic checks, including --help on all installed scripts.

This exposed a bug in bilby_result for python2.7 where print is used as an attribute name (see pipeline #80948). It is forbidden to use reserved keywords as attribute names (in python3, print is just a builtin function). So, I renamed that attribute keys which made sense to me in context.

Edited by Duncan Macleod

Merge request reports

Pipeline #80950 passed

Pipeline passed for 262c0607 on duncanmmacleod:py27-keyword-attribute

Approval is optional
Ready to merge by members who can write to the target branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading