Speed up core.prior classes
To solve issue #416 (closed)
Merge request reports
Activity
- Resolved by Gregory Ashton
- Automatically resolved by Liting Xiao
added 1 commit
- 000a24e1 - Changed prob() in StudentT to a more stable expression
- Resolved by Liting Xiao
@gregory.ashton Before someone else approves, I found out that
Beta
is also using scipy, just was buried so that I didn't catch it before.And a second thing, the current Beta
prob()
andln_prob()
have bugs I think. Specifically it's line 1911 and 1912 forprob()
inprior.py
. And also a similar issue inln_prob()
.a) it's not returning
pdf
, but returningspdf
. So it's not taking out the infinities.b) it's buggy because of this
spdf[np.isfinite]
.Working on changing it now.
Edited by Liting Xiao
added 1 commit
- 52e9331a - Code changes and added test for core.prior.Beta
Great, thanks @liting.xiao this looks ready to go. Nice work!
changed milestone to %0.6.0
added Efficiency label
changed milestone to %0.5.9
mentioned in commit c1984e43
mentioned in issue #416 (closed)
mentioned in merge request !332 (merged)