Skip to content
Snippets Groups Projects

Speed up core.prior classes

Merged Liting Xiao requested to merge (removed):speed-up-prior into master
All threads resolved!

To solve issue #416 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Colm Talbot
  • Liting Xiao added 1 commit

    added 1 commit

    • 000a24e1 - Changed prob() in StudentT to a more stable expression

    Compare with previous version

  • Liting Xiao added 1 commit

    added 1 commit

    Compare with previous version

  • Gregory Ashton resolved all threads

    resolved all threads

  • Gregory Ashton approved this merge request

    approved this merge request

    • Resolved by Liting Xiao

      @gregory.ashton Before someone else approves, I found out that Beta is also using scipy, just was buried so that I didn't catch it before.

      And a second thing, the current Beta prob() and ln_prob() have bugs I think. Specifically it's line 1911 and 1912 for prob() in prior.py. And also a similar issue in ln_prob().

      a) it's not returning pdf, but returning spdf. So it's not taking out the infinities.

      b) it's buggy because of this spdf[np.isfinite].

      Working on changing it now.

      Screen_Shot_2019-10-21_at_8.58.34_PM

      Edited by Liting Xiao
  • Liting Xiao resolved all threads

    resolved all threads

  • Liting Xiao added 1 commit

    added 1 commit

    • 52e9331a - Code changes and added test for core.prior.Beta

    Compare with previous version

  • Liting Xiao resolved all threads

    resolved all threads

  • Gregory Ashton approved this merge request

    approved this merge request

  • Great, thanks @liting.xiao this looks ready to go. Nice work!

  • Moritz Huebner approved this merge request

    approved this merge request

  • Moritz Huebner changed milestone to %0.6.0

    changed milestone to %0.6.0

  • Gregory Ashton changed milestone to %0.5.9

    changed milestone to %0.5.9

  • Gregory Ashton mentioned in commit c1984e43

    mentioned in commit c1984e43

  • mentioned in issue #416 (closed)

  • Colm Talbot mentioned in merge request !332 (merged)

    mentioned in merge request !332 (merged)

  • Please register or sign in to reply
    Loading