Add in plane spins

This MR will add the magnitude of the in-plane spin for both components in post-processing. I'm not 100% sold on the name yet.

added 1 deleted label

could have chi_1_inplane (or chi_1_inPlane if camelCase is allowed) instead of chi_1_perp.

This next thing is also way overkill, but it should nominally also be noted which spin-frame is used to make this statement

https://git.ligo.org/lscsoft/lalsuite/blob/master/lalsimulation/lib/LALSimInspiralWaveformFlags.h#L92

(the default is LAL_SIM_INSPIRAL_FRAME_AXIS_ORBITAL_L, as defined here)

If we want to be extra careful with what the spins could be perpendicular to

I agree that we should make sure this is clear, do you have a specific recommendation.

I like chi_1_inplane, or maybe chi_1_in_plane as long as that isn't too many underscores.

marked as a Work In Progress

added 1 commit

• 6874dd50 - Change to updated in plane names

Compare with previous version

unmarked as a Work In Progress

added 19 commits

• 6874dd50...35a5cc6d - 18 commits from branch master
• 5962d39a - Merge branch 'master' into 'add-in-plane-spins'

Compare with previous version

changed milestone to %0.6.0

approved this merge request

approved this merge request

mentioned in commit 99f79d1e

merged