updated iota to theta_jn in tutorials

Updates the parameter representing angle between angular momentum and line of sight from 'iota' to 'theta_jn'. This brings the tutorial's parameter naming conventions up to date with the rest of the code.

iota is (historically) used to be the angle between the orbital angular momentum and th line of sight, where theta_jn is the angle between the total angular momentum (both spin and orbital) and the line of sight. This commit mixes those conventions a bit, could you double check what definition you're meaning and make sure you're consistent?

@matthew.carney, thanks for updating this.

Good catch Carl, for reference, theta_jn as we define it is the angle between the total angular momentum and the line-of-sight. @matthew.carney please update the comment.

added Example/Tutorial + 1 deleted label

changed milestone to %0.6.4

changed milestone to %0.6.5

Ping @matthew.carney

This is rapidly going stale. @colm.talbot or @cjhaster could you check this branch out, update the comment, and push a new MR (I don't think you'll be able to must to @matthew.carney's branch)? :)

changed milestone to %0.6.6

changed milestone to %0.6.7

changed milestone to %0.6.8

approved this merge request

approved this merge request

We are just going to merge this and fix the typo in a new MR

merged

mentioned in commit 7fd4c279

mentioned in issue #479 (closed)