Skip to content
Snippets Groups Projects

Fix ROQ scaling checks

Merged Shanika Galaudage requested to merge shanika.galaudage/bilby:fix_ROQ_scaling into master

It appears that the ROQ check is updating the roq_params values, and as it iterates through ifos, it scales the roq_params each time.

This merge request makes the following changes:

  • prevents the roq_params from being altered at any stage
  • requires the roq_scale_factor to be passed to the likelihood

Closes bilby_pipe#147 (closed)

@gregory.ashton @colm.talbot

Edited by Shanika Galaudage

Merge request reports

Pipeline #93881 passed

Pipeline passed for 7ca14952 on shanika.galaudage:fix_ROQ_scaling

Approved by

Merged by Gregory AshtonGregory Ashton 5 years ago (Dec 16, 2019 11:35pm UTC)

Pipeline #94644 failed

Pipeline failed for f2af620b on master

Test coverage 72.00% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading