Resolve "Injection in frequency domain doesn't update time domain strain" (!680) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Merged Moritz Huebner requested to merge 441-injection-in-frequency-domain-doesn-t-update-time-domain-strain into master 5 years ago

Closes #441 (closed)

Requires !682 (merged)

Edited 5 years ago by Moritz Huebner

Approved by

Activity

Moritz Huebner added Bug + 1 deleted label 5 years ago

added Bug + 1 deleted label
Moritz Huebner added 1 commit 5 years ago
added 1 commit

5437684e - Correctly update time domain strain after an injection

Compare with previous version
Moritz Huebner unmarked as a Work In Progress 5 years ago

unmarked as a Work In Progress
Moritz Huebner @moritz.huebner · 5 years ago

Author Maintainer

@sylvia.biscoveanu This should resolve the issue
Colm Talbot @colm.talbot · 5 years ago

Maintainer

It looks like this is being hit by the updated versions of the constants in lalsuite (lalsuite!1079 (merged)).
Moritz Huebner added 2 commits 5 years ago
added 2 commits

d87d31bb - Using new LAL value for MSun

8a88ba00 - Merge branch '446-tests-on-master-failing-due-to-new-solar-mass-in-lal' into...

Compare with previous version
Moritz Huebner changed the description 5 years ago

changed the description
Moritz Huebner added 3 commits 5 years ago
added 3 commits

3a816503 - Fixed precomputed likelihood value to match result due to change in solar mass

d3e25a00 - Fixed precomputed likelihood value to match result due to change in solar mass

40e081a3 - Merge branch '446-tests-on-master-failing-due-to-new-solar-mass-in-lal' into...

Compare with previous version
Moritz Huebner changed milestone to %0.6.2 5 years ago

changed milestone to %0.6.2
Moritz Huebner added 7 commits 5 years ago
added 7 commits

b45aba19 - Temporarily remove 3.6 testing

148a6ee3 - Merge branch 'temporarily_remove_3.6_testing' into...

63f979e9 - Run 3.6 tests with different docker image

6210e064 - Merge branch 'testing_test' into temporarily_remove_3.6_testing

632feb04 - Merge branch 'temporarily_remove_3.6_testing' into...

044f41d6 - Removed python 3.6 tests again

f2e8c5eb - Merge branch '446-tests-on-master-failing-due-to-new-solar-mass-in-lal' into...

Compare with previous version
Toggle commit list
Shanika Galaudage approved this merge request 5 years ago

approved this merge request
Moritz Huebner mentioned in merge request !685 (merged) 5 years ago

mentioned in merge request !685 (merged)
Paul Lasky approved this merge request 5 years ago

approved this merge request
Paul Lasky mentioned in commit eef57b3b 5 years ago

mentioned in commit eef57b3b
Paul Lasky merged 5 years ago

merged

Please register or sign in to reply