Adds back the python36 test (!695) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Merged Gregory Ashton requested to merge add-back-python-36-test into master 5 years ago

The python36 test was removed because the Docker file wasn't updating. This has now been resolved on Dockerhub: https://hub.docker.com/repository/docker/bilbydev/v2-dockerfile-test-suite-python36 so this adds back the test.

During the MR, the CPNest sampler was failing only the python 3.6 test due to this issue: https://github.com/johnveitch/cpnest/issues/62 to remedy this, I added resume=False. This isn't ideal as it doesn't test the full behaviour, but it is better to test some functionality than none.

Edited 5 years ago by Gregory Ashton

Activity

Gregory Ashton added 1 commit 5 years ago
added 1 commit

7819d0ea - Remove resume from cpnest

Compare with previous version
Gregory Ashton added Testing label 5 years ago

added Testing label
Gregory Ashton changed milestone to %0.6.4 5 years ago

changed milestone to %0.6.4
Gregory Ashton changed the description 5 years ago

changed the description
Colm Talbot approved this merge request 5 years ago

approved this merge request
Moritz Huebner approved this merge request 5 years ago

approved this merge request
Gregory Ashton merged 5 years ago

merged
Gregory Ashton mentioned in commit 2584e998 5 years ago

mentioned in commit 2584e998

Please register or sign in to reply