add auto generated dockerfiles
This MR adds a template for the docker files to hopefully reduce repetition in modifying the files. A single change to the template will propagate to the other files.
I also switched to the conda-forge
version of multinest
and ultranest
. For the former this is a significant simplification.
Are people happy to make this change? Is it possible to remove all of the old docker files without breaking everything?
Also, I gave the files new names, rather than overwriting the existing ones, although I'm happy to go either way.
There may be a clever way to make the script run automatically when the template is changed, but I don't know how to do that.
@gregory.ashton @matthew-pitkin I know you've interacted with these files in the past.
Merge request reports
Activity
added Infrastructure Refactoring labels
I'd be happy to go with this, it will need some coordination with our dockerhub page which builds the images. The easiest thing is to add new containers, get them to build, then switch off the auto builds for the old ones, and finally update the gitlab CI to use the new images.
I'd suggest we keep the old ones around and the old images as there could be people using them and it costs us nothing. This is why I started versioning the files adding a "v2" to the current crop. It could be useful to continue this by calling this "v3", what do you think?
- Resolved by Colm Talbot
Okay, I suggest we get this merged during the post-1.0 phase. I'd like to suggest we
-
Rename the output files to match the current names, i.e.
v2-dockerfile-test-suite-python35
this will then mean we don't have to change things on dockerhub, things should just work (but we should check). - Add an automated check that the autogenerated files match those stored in the repo to avoid things getting out of sync
-
Remove the now very obsolete
Dockerfile*
files.
@colm.talbot are you able to make these changes? I'm also happy to do it if needed.
Edited by Colm Talbot -
Rename the output files to match the current names, i.e.
added 163 commits
-
ac975ae1...5428c2ee - 159 commits from branch
master
- 3abdc229 - Merge remote-tracking branch 'origin' into auto-generate-dockerfiles
- 3e2ec8ba - remove very old dockerfiles
- a9797ead - remove bad container files
- 77819b68 - update auto generated dockerfiles
Toggle commit list-
ac975ae1...5428c2ee - 159 commits from branch
added 1 commit
- f56f4467 - Add a test that the containers are up to date
added 1 commit
- a1bc1e68 - Update the dockerfile without running the auto-gen script to check it fails
@moritz.huebner this is good to go.
mentioned in commit 06b3a240
changed milestone to %1.0.2