Skip to content
Snippets Groups Projects

add auto generated dockerfiles

Merged Colm Talbot requested to merge auto-generate-dockerfiles into master
All threads resolved!

This MR adds a template for the docker files to hopefully reduce repetition in modifying the files. A single change to the template will propagate to the other files.

I also switched to the conda-forge version of multinest and ultranest. For the former this is a significant simplification.

Are people happy to make this change? Is it possible to remove all of the old docker files without breaking everything?

Also, I gave the files new names, rather than overwriting the existing ones, although I'm happy to go either way.

There may be a clever way to make the script run automatically when the template is changed, but I don't know how to do that.

@gregory.ashton @matthew-pitkin I know you've interacted with these files in the past.

Merge request reports

Pipeline #152434 passed

Pipeline passed for 6b74ba15 on auto-generate-dockerfiles

Test coverage 61.00% (0.00%) from 1 job
Approved by

Merged by Moritz HuebnerMoritz Huebner 4 years ago (Sep 4, 2020 12:26pm UTC)

Merge details

  • Changes merged into master with 06b3a240 (commits were squashed).
  • Deleted the source branch.

Pipeline #153237 passed with warnings

Pipeline passed with warnings for 06b3a240 on master

Test coverage 72.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading