Fixed bugs with changing max/min of priors within Cosmological and Interped classes

Within the Interped (core) class, it now yields an error if the maximum is increased (or minimum decreased) post-initialization. The attributes min_limit and max_limit keep track of the original boundaries of the provided arrays, such that the maximum can be decreased and then later increased back to the original value without yielding errors.

Within the Cosmological (gw) class, the distance arrays are recalculated when the boundaries are extended, so the maximum can be increased (or minimum decreased) post-initialization.

approved this merge request

Is it possible to put a test together for this? I.e. does anyone have a script demonstrating the issue which we can turn into a CI test?

resolved all threads

added 1 commit

• 052b121a - Changed logger.error to raise ValueError

Compare with previous version

added 14 commits

• 052b121a...2d9665c8 - 12 commits from branch lscsoft:master
• e4eb26b5 - Merge branch 'master' of https://git.ligo.org/lscsoft/bilby into fix_distance_prior_maximum
• 3d95fd40 - Added prior maximum increase test to GW prior tests

Compare with previous version

added 1 commit

• 8edefd64 - Modified test for GW priors to check mean instead of hist values

Compare with previous version

added 1 commit

• 2812b671 - Removed seed dependency, relaxed test condition to mean > 10000

Compare with previous version

approved this merge request

approved this merge request

changed milestone to %1.0.1

added Priors label

merged

mentioned in commit 514b1bd9

mentioned in issue #474 (closed)