Skip to content
Snippets Groups Projects

Now passes a copy of the reference_params dict into the condition func

Merged Now passes a copy of the reference_params dict into the condition func
make_condition_evaluation_safer into master
Merged Moritz Huebner requested to merge make_condition_evaluation_safer into master

In theory, users could get unexpected behaviour if they add key/value pairs to reference_params via their condition function. This fixes it.

Merge request reports

Pipeline #142680 passed

Stage: test

Pipeline passed for 657ca60d on make_condition_evaluation_safer

Test coverage 57.00% (0.00%) from 1 job
Approval is optional

Merged by Moritz HuebnerMoritz Huebner 4 years ago (Jul 29, 2020 6:06am UTC)

Pipeline #143664 passed with warnings

Stage: test
Stage: deploy

Pipeline passed with warnings for 235529b3 on master

Test coverage 57.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply