Skip to content

Allow sampling in aligned spin and spin magnitude

Colm Talbot requested to merge magnitude-aligned-spin-sampling into master

This MR will allow us to sample in the spin magnitude and the aligned component of the spin, rather than magnitude and tilt.

The reason to do this is that the aligned component of the spin is the best measured per component spin parameter. From preliminary tests, it looks like this will improve convergence with at least MultiNest.

Currently, this will only support the vanilla flat in magnitude, isotropic in orientation prior. It would take more effort to figure out the generic case.

This required making the CBCPriorDict a subclass of the ConditionalPriorDict, I know that people have reported seeing issues with this in the past, but I don't remember what they were. @moritz.huebner @rory-smith?

EDIT I think the issue with the conditional priors was the _check_if_prior_can_be_sampled method which I have removed. That was falling over for some conditions/constraints. I think the current version should be suitably robust.

Edited by Colm Talbot

Merge request reports