Resolve "Plot_time_domain_data and time of coalescence for waveform SEOBNRv4" (!909) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 25 March 2025 starting at approximately 8:30am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk.

Merged Colm Talbot requested to merge 551-plot_time_domain_data-and-time-of-coalescence-for-waveform-seobnrv4 into master 4 years ago

This MR fixes the correction of the epoch in time domain waveforms when using a segment duration that is not a power of two, e.g., SEOBNRv4 with 5s duration.

I don't think that this will impact O3 analyses, but I wanted to check. Bilby runs are just frequency domain, right? @christopher-berry @cjhaster @gregory.ashton

Closes #551 (closed)

Edited 4 years ago by Colm Talbot

Approval is optional

Activity

Colm Talbot added Bug High priority labels 4 years ago

added Bug High priority labels
Colm Talbot added 1 commit 4 years ago
added 1 commit

9214f67b - Fix epoch correction

Compare with previous version
Colm Talbot marked this merge request as ready 4 years ago

marked this merge request as ready
Colm Talbot changed the description 4 years ago

changed the description
Sylvia Biscoveanu approved this merge request 4 years ago

approved this merge request
Moritz Huebner approved this merge request 4 years ago

approved this merge request
Moritz Huebner changed milestone to %1.1.0 4 years ago

changed milestone to %1.1.0
Moritz Huebner mentioned in commit 4a979f4c 4 years ago

mentioned in commit 4a979f4c
Moritz Huebner merged 4 years ago

merged
Moritz Huebner mentioned in merge request !928 (merged) 4 years ago

mentioned in merge request !928 (merged)

Please register or sign in to reply