Skip to content
Snippets Groups Projects

Waveform generator starting time

Merged Moritz Huebner requested to merge waveform_generator_starting_time into master
1 unresolved thread

Adds an optional argument starting_time=0 to the waveform generator. This is passed on for the creation of the time_array in the respective utils function. This is necessary because for some waveform models we have to allow starting times < 0 because of the conventions used within that package.

https://git.ligo.org/Monash/tupak/issues/125

Edited by Moritz Huebner

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
243 250 self.__sampling_frequency = sampling_frequency
244 251 self.__frequency_array_updated = False
245 252 self.__time_array_updated = False
253
254 @property
255 def starting_time(self):
  • One other question and just to clarify. Is this the starting time of the data, not of the signal itself?

  • Moritz Huebner added 145 commits

    added 145 commits

    • 11868f5d...e1df746c - 141 commits from branch master
    • b76d5cde - Merge branch 'master' into waveform_generator_starting_time
    • f68e71eb - Fixed a bug in create_time_series that produced incorrect time_arrays if a…
    • 47931906 - Fixed a bug in create_time_series that produced incorrect time_arrays if a…
    • 36d594b8 - Renamed starting_time -> start_time

    Compare with previous version

  • Please register or sign in to reply
    Loading