Skip to content
Snippets Groups Projects

Add functionality to strain data

Merged Gregory Ashton requested to merge add-functionality-to-strain-data into master

A set of changes to improve our handling of strain data. The ultimate aim is to handle all strain data in one unified approach.

Tasks:

  • Add time domain data and automatically get the frequency domain (partial fix for #121 (closed))
  • Add methods for setting data from CSV files of time-domain strain [removed as this can be done easily with gwpy]
  • Add units and explanations for the normalization
  • Add set_from_gwpy method
  • Encapsulate all other gwpy calls
  • Add a create_psd method that turns the strain data into a power spectral density.
  • Check documentation

@paul-lasky @colm.talbot @moritz.huebner @nikhil.sarin

Edited by Gregory Ashton

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Fix windowing to be the proper roll off
    • Remove data crop
    Edited by Gregory Ashton
  • Gregory Ashton resolved all discussions

    resolved all discussions

  • Gregory Ashton added 7 commits

    added 7 commits

    • a3986dc6 - Fix notation on units
    • a4200ddc - Convert logic of get_open_strain to methods of strain_data
    • f045fcdd - Further bug fixes and improvements
    • 234ff4cd - Update from using alpha to a time of roll off
    • 7cd604f6 - Simplify set_from_frame
    • 1fe13b4c - Make roll_off an attribute and fix bug in the PSD roll off
    • 33bc0398 - Move low pass and window to be called by default when generating td data

    Compare with previous version

  • Gregory Ashton added 2 commits

    added 2 commits

    Compare with previous version

  • Gregory Ashton marked the checklist item Add a create_psd method that turns the strain data into a power spectral density. as completed

    marked the checklist item Add a create_psd method that turns the strain data into a power spectral density. as completed

  • Gregory Ashton marked the checklist item Encapsulate all other gwpy calls as completed

    marked the checklist item Encapsulate all other gwpy calls as completed

  • @colm.talbot I've noticed that there is some work that could be done on PowerSpectralDensity which mirrors what is done here.

    I'd personally like to see (a) PSD be in its own file for convienience, and (b) it be settable from a bunch of methods (rather than the init take a load of different input). What is your feeling? I don't want to impose my views everywhere :P

  • (a) Why (I'm not trying to be difficult, I just don't know why this would be better)?

    (b) I think this comes down to a question of whether we want users to change the existing PSD or make a new different one. I'd personally vote for the latter, although the former may be more in line with the implementation of the StrainData.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading