Fix _base_roq_waveform

Hi all,

@rory-smith and I found a bug in the way the ROQ waveforms are being calculated when we add tidal deformabilites lambda_1 and lambda_2. We solved this issue by adding a couple of lines of code to the base_roq_waveform function. The error was caused because the waveform dictionary gets overwritten after this block of code: https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/gw/source.py#L517

To check that the updated version works, we ran two different tests: one with the current bilby version, and one with the updated version. You can see that the first plot (which uses the current version of bilby) results in biased constraints, whereas our updated version (second plot) solves this issue.

Let us know if you have any questions. Thanks!

approved this merge request

approved this merge request

Hi @colm.talbot , @sylvia.biscoveanu . We recently found another issue in the new _base_roq_waveform. I sampled lambda_1, lambda_2 and distance (with distance marginalisation turned on) and the results are still biased. @rory-smith and I are looking into it.

resolved all threads

merged

mentioned in commit f58ae0f5

changed milestone to %1.1.2

added Bug ROQ labels