Skip to content
Snippets Groups Projects

bilby/gw/likelihood.py: speed up the spline interpolation in ROQ

Merged Soichiro Morisaki requested to merge soichiro/bilby:faster_roq_interpolation into master
All threads resolved!

This MR speeds up the spline interpolation of d_inner_h_tc_array in ROQ.

Since it is apriori known that the time interval of samples is constant and 5 samples are used, the spline method tuned for that case is much faster than scipy.interpolate.interp1d. The algorithm is described in https://dcc.ligo.org/LIGO-T2100224. This change speeds up the interpolation by a factor of ~8. This can be a significant speedup for compact ROQ bases. For example, this change speeds up the overall ROQ likelihood evaluation by a factor of ~2 for PhenomD bases with size of ~70.

Edited by Soichiro Morisaki

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Soichiro Morisaki resolved all threads

    resolved all threads

  • added 2 commits

    • d78ca381 - bilby/gw/likelihood.py: do not define multiple variables in a single line
    • de3aa4b4 - bilby/gw/likelihood.py: round down the closest time sample in ROQ

    Compare with previous version

  • @colm.talbot I have addressed your comments (including those on multiple definitions in a single line).

  • Gregory Ashton approved this merge request

    approved this merge request

  • Moritz Huebner changed milestone to %1.1.3

    changed milestone to %1.1.3

  • Moritz Huebner approved this merge request

    approved this merge request

  • Moritz Huebner mentioned in commit 59a48307

    mentioned in commit 59a48307

  • Colm Talbot mentioned in merge request !987 (closed)

    mentioned in merge request !987 (closed)

  • Soichiro Morisaki mentioned in merge request !1241 (merged)

    mentioned in merge request !1241 (merged)

  • Please register or sign in to reply
    Loading