Allow waveform_generator to not have to be initialised with the duration and sampling frequency

This allows the waveform generator to be given None for the sampling frequency and duration (in this state, it therefore can't be used to generate an injection). Then, when passed to the likelihood, a check if performed to see if those attributes are set. If they are None, they are set from the data, and if they disagree with the data, an error is raised.

I can't decide if this is just useless bloat, or actually useful.

Closes #127 (closed)

I think this is useful. It isn't clear to me that the code actually overwrites the values in the wfg.

I would suggest that the messages are changed a little:

• debug when it sets the wfg parameters from None.
• info or warning when it changes the parameters in the wfg. I think this is an important thing that people should care about.

added 1 commit

• e481d05d - Improve warning messages when overwriting the WFG

Compare with previous version

Okay thanks @colm.talbot, I've updated accordingly.

merged

mentioned in commit 3ea94125