Modify inject signal

This restructures some functionality surrounding the inject_signal method.

• Added inject_signal_from_waveform_generator and inject_signal_from_waveform_polarizations that are slightly less confusing to use than inject_signal.
• Removed if/else statement that checks size of the injected signal. The injection will now just fail if that condition is now not fulfilled. It was already breaking before, but at a different place.
• Added explicit tests for these methods.

test/detector_test.py

@@ -523,16 +523,29 @@ class TestReferenceInterferometerList(unittest.TestCase):
             phase=1.3, geocent_time=1126259642.413, ra=1.375, dec=-1.2108)
         injection_polarizations = waveform_generator.frequency_domain_strain(parameters=injection_parameters)
         self.ifos.inject_signal(parameters=injection_parameters, injection_polarizations=injection_polarizations)
+        current_dir = os.path.dirname(os.path.abspath(inspect.getfile(inspect.currentframe())))
+        self.reference_ifos = bilby.gw.detector.InterferometerList.from_hdf5(current_dir + '/reference_ifos/ifo_H1L1V1.h5')
 
     def tearDown(self):
         del self.ifos
 
-    def test_test(self):
+    def test_reference_ifo_strain_data(self):
         if sys.version_info < (3, 0):
             return
-        current_dir = os.path.dirname(os.path.abspath(inspect.getfile(inspect.currentframe())))
-        reference_ifos = bilby.gw.detector.InterferometerList.from_hdf5(current_dir + '/reference_ifos/ifo_H1L1V1.h5')
-        self.assertEqual(reference_ifos, self.ifos)
+        for reference_ifo, ifo in zip(self.reference_ifos, self.ifos):
+            self.assertEqual(reference_ifo.strain_data, ifo.strain_data)
+
+    def test_reference_ifo_geometry(self):
+        if sys.version_info < (3, 0):
+            return
+        for reference_ifo, ifo in zip(self.reference_ifos, self.ifos):
+            self.assertEqual(reference_ifo.geometry, ifo.geometry)
+
+    def test_reference_ifo_psd(self):
+        if sys.version_info < (3, 0):
+            return
+        for reference_ifo, ifo in zip(self.reference_ifos, self.ifos):
+            self.assertEqual(reference_ifo.power_spectral_density, ifo.power_spectral_density)
 
 
 class TestInterferometerEquals(unittest.TestCase):