Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • B bilby_pipe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • bilby_pipe
  • Merge requests
  • !371

Support for any laldict waveform option

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Cecilio Garcia-Quiros requested to merge cecilio.garcia-quiros/bilby_pipe:lal-wf-dict into master Nov 10, 2020
  • Overview 19
  • Commits 20
  • Pipelines 0
  • Changes 1

Hi @gregory.ashton, @colm.talbot,

In order to avoid having to add manually each option of the LAL dictionary to the bilby _base_lal_cbc_fd_waveform function, as done in bilby!845 (closed), I use the waveform_arguments_dict object of bilby_pipe to build a lal_waveform_dictionary bilby object.

In the config_bilby_pipe.ini now I specify for example:

waveform-arguments-dict={PhenomXHMThresholdMband:0., PhenomXPrecVersion:102, PhenomXPHMTwistPhenomHM:1}

where the keys of this dictionary are part of the name of the LAL function to insert that option e.g. lalsim.SimInspiralWaveformParamsInsertPhenomXHMThresholdMband. So in this way you can insert any of the options listed in https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalsimulation/lib/LALSimInspiralWaveformParams.h just by specifying in the key what goes after XLALSimInspiralWaveformParamsInsert.

I checked that these values are correctly propagated to bilby when doing bilby_pipe_generation config_bilby_pipe.ini

Let me know if you find this useful or sensible and if there would be other parts of the code to be modified.

I solved some CI problems but I would need a bit of help for resolving the precommits step since it doesn't throw any informative error.

Edited Nov 10, 2020 by Cecilio Garcia-Quiros
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: lal-wf-dict