Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • B bilby_pipe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • bilby_pipe
  • Merge requests
  • !477

Always set npool if request-cpus>1

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michael Williams requested to merge michael.williams/bilby_pipe:request-cpus-npool into master Sep 27, 2022
  • Overview 0
  • Commits 3
  • Pipelines 2
  • Changes 2

Now that the samplers have been refactored bilby (bilby!1043 (merged)), npool is keyword argument for all of the samplers. This means we no longer need the logic in Input.update_sampler_kwargs_conditional_on_request_cpus that sets npool (or equivalent) based on the sampler being used.

bilby version

This change requires bilby>=1.2.0 but this was already pinned in !472 (merged)

Unit tests

I've added a simple unit test to make sure the logic is correct.

End-to-end tests

I've run tests with dynesty, bilby_mcmc, nessai and pymultinest. The first three should all use npool whereas multinest should ignore it. The output directory is here: https://ldas-jobs.ligo.caltech.edu/~michael.williams/bilby-dev/bilby-pipe/request-cpus-npool/

  • dynesty & bilby_mcmc: the logs show the multiprocessing pool starting with the correct number of cores (4)
  • nessai: npool is correctly translated to n_pool and the log shows the multiprocessing pool starting
  • multinest: no pool is started but sampling runs to completion
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: request-cpus-npool