Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • G glue
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • glue
  • Merge requests
  • !107

Draft: Improve the lint configuration and fix some

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Duncan Macleod requested to merge duncanmmacleod/glue:lint into master Jan 17, 2022
  • Overview 0
  • Commits 5
  • Pipelines 3
  • Changes 7

This MR improves the configuration for flake8 as follows

  • ignore a lot of files that are deprecated
  • ignore a lot of warnings we don't have the energy to care about (most best-practice syntax violations...), so we can concentrate on mort important ones (unused imports etc)

and then fixes a couple of wee lint issues in the test scripts.

The idea here is that we should get the flake8 job to pass by ignoring stuff we can't/won't fix (right now), mainly so that future changes can't introduce new violations of the stuff we do care about (unused imports etc). We can reintroduce more thorough checks later.

Edited Jan 17, 2022 by Duncan Macleod
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: lint