Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
G
gracedb
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1
    • Merge Requests 1
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • gracedb
  • Issues
  • #185

Closed
Open
Opened Dec 10, 2019 by Peter Shawhan@peter-shawhan

Missing f.close() for the coinc.xml file in serialize.py

The changes between v2.7.1 and v2.8.0 introduced this bug (if I am understanding things correctly). The code in gracedb/events/serialize.py,

    file_path = os.path.join(root_dir, xml_fname)
    f = VersionedFile(file_path, 'w')
    xmldoc.write(f.file)

is not followed by an f.close() line.

(I tracked this down after Leo noticed that the symlink was not created for the coinc.xml file, and the close method for a VersionedFile object is what creates/updates the symlink.)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: lscsoft/gracedb#185