Skip to content
Snippets Groups Projects

WIP: Add GRB FAR field

Closed Brandon Piotrzkowski requested to merge brandon.piotrzkowski/gracedb:fargrb into python3
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
652 652 break
653 653 event.trigger_id = trigger_id
654 654
655 # Swift subthreshold GRBs have an extra FAR field
656 if 'FAR' in VOEvent_params:
657 event.far = float(VOEvent_params.get('FAR').get('value'))
  • Are there any other changes needed to add a field to external events?

  • This is an additional field for SWIFT events that is going to be included in the initial data upload. That change to translator.py is one of a few changes that need to take place, but it's manageable. It would be helpful to speed these changes up to:

    • decide on the name of the name of the field (obviously)
    • provide a sample "initial.data" xml file with the name included.

    Having the sample file in place is going to make testing the upload much faster. There are a few other places were changes have to take place, including the client code and the api backend, but i can do those pretty quickly once we decided on the name of the field.

  • added 1 commit

    • 4c5dfb72 - Use field given by Swift team

    Compare with previous version

  • We are being asked to ingest a VOEvent template that will be used by the Fermi untargeted and Swift subthreshold searches to create external events in GraceDB. The motivation is that trying to upload VOEvents now require many unnecessary fields, which we would want to only require the absolutely necessary ones.

  • Alexander Pace mentioned in commit bc58c4ff

    mentioned in commit bc58c4ff

  • Alexander Pace mentioned in commit 5981ecb6

    mentioned in commit 5981ecb6

  • This change has been tested and approved (https://git.ligo.org/sccb/requests/issues/406) for deployment tomorrow, February 11. I'm closing this merge request.

    Edited by Alexander Pace
  • Please register or sign in to reply
    Loading