Skip to content
Snippets Groups Projects
Commit 596a23b3 authored by Kipp Cannon's avatar Kipp Cannon
Browse files

AppSync: try to fix a race condition in exception reporting

if the call-back to handle a new buffer raises an exception, the lock can
get released in the finally: clause allowing other threads waiting to go to
begin running before the finally: clause re-raises the exception.  if the
thread that starts running hits the assert related to un-processed buffers
then you get that exception instead of the one that really triggered the
failure, making debugging difficult.  this patch moves the call-back to the
very end of the try: clause so that there's no book-keeping left to take
care of in the event that it fails, which should ensure we get the correct
traceback displayed.
parent 19a71e00
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment