Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • GstLAL GstLAL
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • GstLALGstLAL
  • Merge requests
  • !122

Assorted fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Patrick Godwin requested to merge fix-cleanup_typos_prints into master Nov 04, 2021
  • Overview 0
  • Commits 7
  • Pipelines 2
  • Changes 16

While doing some cleanup with the unused imports, I also ran into various issues throughout that this MR fixes:

  • Port various python2 print statements throughout
  • gstlal_inspiral_calc_snr: Move missing_required_options upstream to avoid running into issues where it hasn't been defined yet
  • Fix a couple of StringIO() calls that were not correct. (if StringIO is imported from io, it should be StringIO(), not StringIO.StringIO().
  • chirptime.py file had Windows formatting, so that was converted via dos2unix
  • Fix a couple of undefined variable problems due to typos.
  • Remove unused variable in segments.py
  • Fix wrong return type annotation in segments.py.
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-cleanup_typos_prints