Process injections in online analysis
Finish the development required to process injections in the online analysis.
- Find the injection that corresponds to a particular trigger by sorting the sim inspiral table by gps time. Then append this injection to the coinc event file as a new sim_inspiral table with a single row.
- Fix complaints about missing options in gstlal_inspiral for injection jobs. Allow injection jobs to run without a ranking stat output option, since we don't want the injections to get included in the background estimation.
- DAG level change in gstlal_inspiral_ll_workflow: add the injection filtering layer before the non-injection filtering layer, otherwise the injection jobs have the non-injection jobs as parents and they will never start.
This branch has been tested and runs without errors.
Edited by Rebecca Ewing
Merge request reports
Activity
@wanting.niu The build is failing because there are both tabs and spaces in
inspiral.py:TabError: inconsistent use of tabs and spaces in indentation (inspiral.py, line 417)How are you editing code? most IDE's have a setting for tabs v. spaces. For existing files like
inspiral.py, we're going to use tabs.
@james.kennington There is a space between two tabs (probably typo). I just fix it. Thank you!
added 1 commit
- e7e81edc - fix the unready jobs when running on cluster. filter_online_injection job...
added 1 commit
- 93f34772 - avoid checking missing_zerolag_pdf for injection jobs
added 1 commit
- 321d933f - create gstlal-inspiral-inj jobs in the DAG before creating gstlal-inspiral jobs
added 97 commits
-
321d933f...64852648 - 75 commits from branch
master - 3c32763e - change ConicDocument and do_alert() in GracedBWrapper to get sorted...
- 624b75d7 - add sim_inspiral_table into the kwargs when calling do_alerts() from gracedbwrapper
- 4429aa2c - fix indentation
- 2af20b5a - Apply 1 suggestion(s) to 1 file(s)
- 96c217cd - fix indentation and delete unnecessary
- f271b881 - delete unnecessary line
- 897a8ca5 - put back unintentionally removed lines
- 720fefe3 - move the line
- 493c252c - revert unintentionally deleted lines
- e7708784 - fix intentionally added lines
- ed2e40b7 - fix indentation
- 9d90a524 - fix the indentation
- fbf424d2 - fix the unready jobs when running on cluster. filter_online_injection job...
- f0ede3b2 - fix some issues for running injection jobs
- 5831e666 - update conditions on reading injection
- 90363b15 - fix typo
- 1999d4b1 - fix all the bugs in sim row
- 3e2d2fcd - avoid checking missing_zerolag_pdf for injection jobs
- 0967e3fa - rebase with master
- 17606bcc - fix indentation
- 0a085ba7 - create gstlal-inspiral-inj jobs in the DAG before creating gstlal-inspiral jobs
- 8ddaecef - Merge branch 'test_sim_row_kafka_2' of git.ligo.org:lscsoft/gstlal into inj_test
Toggle commit list-
321d933f...64852648 - 75 commits from branch
added 1 commit
- e33fd72d - gstlal-inspiral/python/inspiral.py: fix handling of injections, writing sim row
added 65 commits
-
e33fd72d...60663b4c - 29 commits from branch
master - 83779d25 - change ConicDocument and do_alert() in GracedBWrapper to get sorted...
- 6703b4a4 - add sim_inspiral_table into the kwargs when calling do_alerts() from gracedbwrapper
- 6e62f39f - fix indentation
- 5f1b15e1 - Apply 1 suggestion(s) to 1 file(s)
- 35c98313 - fix indentation and delete unnecessary
- ce660cb3 - delete unnecessary line
- f94ab600 - put back unintentionally removed lines
- 10e89e12 - move the line
- c1e651be - revert unintentionally deleted lines
- 6f1f89f4 - fix intentionally added lines
- 10516e1b - fix indentation
- 0b410d4f - fix the indentation
- cc8b58ac - fix the unready jobs when running on cluster. filter_online_injection job...
- ba59b9e3 - fix some issues for running injection jobs
- 1e705b5b - update conditions on reading injection
- 7e10700e - fix typo
- b595a2d9 - fix all the bugs in sim row
- a29c4f8b - avoid checking missing_zerolag_pdf for injection jobs
- 0b26e518 - rebase with master
- 2252f6d0 - fix indentation
- ed864887 - create gstlal-inspiral-inj jobs in the DAG before creating gstlal-inspiral jobs
- 88890220 - change ConicDocument and do_alert() in GracedBWrapper to get sorted...
- 39ad3299 - fix indentation and delete unnecessary
- 9f727818 - delete unnecessary line
- fd8b8806 - put back unintentionally removed lines
- fb56186b - move the line
- e0b49f08 - revert unintentionally deleted lines
- 08e65330 - fix intentionally added lines
- e221c36e - fix indentation
- d19aaadf - fix the indentation
- 326805c8 - fix typo
- a46d0d52 - fix all the bugs in sim row
- 0b1e55a4 - rebase with master
- fd324099 - fix indentation
- 12281120 - create gstlal-inspiral-inj jobs in the DAG before creating gstlal-inspiral jobs
- fddc0b8a - gstlal-inspiral/python/inspiral.py: fix handling of injections, writing sim row
Toggle commit list-
e33fd72d...60663b4c - 29 commits from branch
407 407 if getattr(options, option) is None: 408 408 missing_options.append("--%s" %option.replace("_","-")) 409 409 410 if missing_options: 410 if missing_options and options.injections is None: changed this line in version 25 of the diff
added 1 commit
- a9cb13a0 - gstlal-inspiral/bin/gstlal_inspiral: clean up logic around missing options
added 1 commit
- bd1c6228 - gstlal-inspiral/bin/gstlal_inspiral: add a check to make sure ranking stat...
added 1 commit
- 288821f8 - gstlal-inspiral/python/inspiral.py: apply suggestions to injection handling
added 1 commit
- e13b2868 - gstlal-inspiral/bin/gstlal_inspiral: apply one suggestion
added 43 commits
-
e13b2868...78dca50d - 3 commits from branch
master - 9dec6d6c - change ConicDocument and do_alert() in GracedBWrapper to get sorted...
- 8951c1eb - add sim_inspiral_table into the kwargs when calling do_alerts() from gracedbwrapper
- f3c49d7a - fix indentation
- 4d742303 - Apply 1 suggestion(s) to 1 file(s)
- d5bb47fd - fix indentation and delete unnecessary
- 9c3c3f47 - delete unnecessary line
- 96379cb4 - put back unintentionally removed lines
- c12af378 - move the line
- e3a4a508 - revert unintentionally deleted lines
- 41cb7c0c - fix intentionally added lines
- 331b44eb - fix indentation
- 9d48c865 - fix the indentation
- c4b07742 - fix the unready jobs when running on cluster. filter_online_injection job...
- 71875ccb - fix some issues for running injection jobs
- a515d5a2 - update conditions on reading injection
- c8c4d310 - fix typo
- 342a53b7 - fix all the bugs in sim row
- 1c1d2083 - avoid checking missing_zerolag_pdf for injection jobs
- 1ea9c5d9 - rebase with master
- 2a0568ca - fix indentation
- fd470a53 - create gstlal-inspiral-inj jobs in the DAG before creating gstlal-inspiral jobs
- cf46ad14 - change ConicDocument and do_alert() in GracedBWrapper to get sorted...
- 91093fa2 - fix indentation and delete unnecessary
- 360475db - delete unnecessary line
- d7788795 - put back unintentionally removed lines
- 2899934b - move the line
- 018e7690 - revert unintentionally deleted lines
- 181d95ac - fix intentionally added lines
- 76294d37 - fix indentation
- c2e67698 - fix the indentation
- 973c6550 - fix typo
- 66dcfed3 - fix all the bugs in sim row
- a6a7edbf - rebase with master
- 1f8533d3 - fix indentation
- 4bc14352 - create gstlal-inspiral-inj jobs in the DAG before creating gstlal-inspiral jobs
- cf851eb6 - gstlal-inspiral/python/inspiral.py: fix handling of injections, writing sim row
- d6c4a7ef - gstlal-inspiral/bin/gstlal_inspiral: clean up logic around missing options
- 2509b41a - gstlal-inspiral/bin/gstlal_inspiral: add a check to make sure ranking stat...
- de55c1e7 - gstlal-inspiral/python/inspiral.py: apply suggestions to injection handling
- 3ac890ed - gstlal-inspiral/bin/gstlal_inspiral: apply one suggestion
Toggle commit list-
e13b2868...78dca50d - 3 commits from branch
Please register or sign in to reply