Skip to content
Snippets Groups Projects

Logging Patch + Extension of Queues in Injection Streamer

Merged Rachael Huxford requested to merge inj-stream-verbose into master
All threads resolved!

This patch has two goals:

  1. improvement of logging.
    • move print statements to logging
    • move non-production info logging to debug
    • move progress reports under verbose flags
  2. Extension of queues
    • extend queues just after sources to protect against variation in reading from disk

Merge request reports

Pipeline #562515 passed

Pipeline passed for 46af0486 on inj-stream-verbose

Approval is optional

Merged by Rachael HuxfordRachael Huxford 1 year ago (Oct 5, 2023 8:37pm UTC)

Merge details

  • Changes merged into master with 46af0486.
  • Deleted the source branch.

Pipeline #572274 passed

Pipeline passed for 46af0486 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good, just one minor set of suggestions for logging.

  • Rachael Huxford added 1 commit

    added 1 commit

    • b2934c9a - Extension of queues for more stable long-term running.

    Compare with previous version

  • Rachael Huxford added 1 commit

    added 1 commit

    • 193de347 - Extension of queues for more stable long-term running.

    Compare with previous version

  • Rachael Huxford resolved all threads

    resolved all threads

  • Apologize for the late-ness of this comment. But Kipp approved on an East call with the note to change the verbose variable everywhere to options.verbose else it is easy to overwrite that variable by accident without realizing the repercussions.

  • Rachael Huxford added 1 commit

    added 1 commit

    • eb95a069 - Move verbose calls -> options.verbose

    Compare with previous version

  • Rachael Huxford added 4 commits

    added 4 commits

    • 6c8f0514 - 1 commit from branch master
    • 96dfc3d5 - Clean up of logging. Addition of verbose protection against excessive progress reports.
    • c46f0873 - Extension of queues for more stable long-term running.
    • 46af0486 - Move verbose calls -> options.verbose

    Compare with previous version

  • Please register or sign in to reply
    Loading