dtdphi dag fixes

This was entirely busted previously. Mostly minor changes. Feel free to argue for different h5 data storage, I was mainly trying to mimic the structure previously used but it's a little silly to use a group/dataset to store a single attribute. @leo.tsukada might also want a look.

assigned to @patrick.godwin

@ryan.magee, looks like gstlal_inspiral_create_prior_diststats is failing for the online test here due to changes in the expected dtdphi file: https://git.ligo.org/lscsoft/gstlal/-/jobs/1476454

added 1 commit

• f41025d5 - dtdphi: fixed h5py scalar access

Compare with previous version

added 9 commits

• f41025d5...036ca367 - 3 commits from branch master
• 770434d4 - gstlal_inspiral_compute_dtdphideff_cov_matrix: dont approximate pi, change...
• 3da4100a - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs: fix typo that raised an error within an error
• d2464d8a - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs_dag: fix thinko in output generation
• a9819912 - stats/inspiral_extrinsics.py: pass psd file and initial snr ratios through...
• 6015150f - dtdphi: fixed h5py scalar access
• 8bb0866c - Merge branch 'dtdphi-fix-210730' of https://git.ligo.org/lscsoft/gstlal into dtdphi-fix-210730

Compare with previous version

Other than the minor comment above, this looks reasonable to me. I'd generally agree about the hdf5 schema but would also be fine deferring this work and raising an issue about revisiting the schema.

I don't personally care whether or not this is merged, but it is what I needed to do to actually run a dtdphi dag. So I will at least locally be using this patch since we rely on it for EW and IMBH tests. I'm happy to either merge and open an issue or hold off and ask @leo.tsukada or someone else heavily involved in dtdphi to prioritize this over the next week since it would likely deprecate existing files. I believe my patch is backwards compatible.

Yeah, if this is blocking work let's push this forward and make an issue/assign to Leo.

added 1 commit

• fd64ee4c - gstlal_inspiral_compute_dtdphideff_cov_matrix: fix double import

Compare with previous version

added 1 commit

• da6e2911 - gstlal_inspiral_compute_dtdphideff_cov_matrix: fix import. dont push before coffee

Compare with previous version

added 8 commits

• 3629f113 - 1 commit from branch master
• cdb4e576 - gstlal_inspiral_compute_dtdphideff_cov_matrix: dont approximate pi, change...
• cbd70564 - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs: fix typo that raised an error within an error
• 78ced16f - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs_dag: fix thinko in output generation
• 68b568dc - stats/inspiral_extrinsics.py: pass psd file and initial snr ratios through...
• 3274a961 - dtdphi: fixed h5py scalar access
• dd3f941b - gstlal_inspiral_compute_dtdphideff_cov_matrix: fix double import
• 5ff6c4f6 - gstlal_inspiral_compute_dtdphideff_cov_matrix: fix import. dont push before coffee

Compare with previous version

approved this merge request

added 8 commits

• e30b5358 - 1 commit from branch master
• 687a10b3 - gstlal_inspiral_compute_dtdphideff_cov_matrix: dont approximate pi, change...
• 2b79402e - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs: fix typo that raised an error within an error
• b41179d0 - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs_dag: fix thinko in output generation
• d3c210f9 - stats/inspiral_extrinsics.py: pass psd file and initial snr ratios through...
• 71baeb4f - dtdphi: fixed h5py scalar access
• cd7b4d34 - gstlal_inspiral_compute_dtdphideff_cov_matrix: fix double import
• 4972a321 - gstlal_inspiral_compute_dtdphideff_cov_matrix: fix import. dont push before coffee

Compare with previous version

merged