first iteration of __isub__ method in RankingStat

requested review from @prathamesh.joshi

assigned to @leo.tsukada

added 1 commit

• ba92d904 - work around for subtraction of BinnedLnPDF class with sanity check of negative...

Compare with previous version

added 1 commit

• 9e78c4b4 - work around for subtraction of BinnedLnPDF class with sanity check of negative...

Compare with previous version

added 2 commits

• 67bf7131 - Introduce __isub__ method in RankingStat class
• 4ef77cd9 - work around for subtraction of BinnedLnPDF class with sanity check of negative...

Compare with previous version

added 62 commits

• 4ef77cd9...5b3cae08 - 60 commits from branch offline_new-workflow
• 93d057a2 - Introduce __isub__ method in RankingStat class
• 0a2e5d29 - work around for subtraction of BinnedLnPDF class with sanity check of negative...

Compare with previous version

added 1 commit

• f962dd2f - Introduce __isub__ method in RankingStat class

Compare with previous version

resolved all threads

@prathamesh.joshi
I realized this MR was not merged yet and had some conflict with upstream that needed a manual fix, so I did. are you good to get this merged to offline branch? Then, probably i would want to add a new entry in this review item list?

Also, to make sure, I suppose this isub feature will be necessary for the final catalog rerank eventually to exclude bg samples from ER15, but we still need to modify the rerank workflow that actually does the bg subtraction based on given start or stop gps time, right? or have you made the dev yet?

merged

resolved all threads