Skip to content
Snippets Groups Projects

add workflow to aggregate the marg_dist, trigger, and inj-trigger for a combined rank

Closed add workflow to aggregate the marg_dist, trigger, and inj-trigger for a combined rank
offline_new-workflow_combine_rank into offline_new-workflow
4 unresolved threads
Closed Wanting Niu requested to merge offline_new-workflow_combine_rank into offline_new-workflow
4 unresolved threads
  • We want to add a structure in rank workflow that can support ranking of combined noise background, triggers, and injection-triggers (if any) over different chunks.
  • For SSM full-rank analysis, we will combine the ranks over chunks as O3 did.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
gstlal-inspiral/bin/gstlal_inspiral_workflow
131 131 else:
132 132 median_psd = DataCache.find(DataType.MEDIAN_PSD, root=config.data.data_dir)
133 133 svd_bank = DataCache.find(DataType.SVD_BANK, root=config.data.data_dir, svd_bins="*")
134 dist_stats = DataCache.find(DataType.MARG_DIST_STATS, root=config.data.filter_dir, svd_bins="*")
135 134
136 triggers = DataCache.find(DataType.TRIGGERS, root=config.data.filter_dir, svd_bins="*")
137 if config.injections.filter:
138 inj_triggers = DataCache.find(DataType.TRIGGERS, root=config.data.injection_dir, svd_bins="*", subtype="*")
139 injections = DataCache.find(DataType.SPLIT_INJECTIONS, root=config.data.injection_dir, svd_bins="*", subtype="*")
140 triggers += inj_triggers
135 if config.rank.combine_rank:
  • Prathamesh Joshi
    Prathamesh Joshi @prathamesh.joshi ·
    Developer

    I would suggest not having an explicit config.rank.combine_rank flag. Instead, it seems better to assume there are always multiple filter dirs to combine, and if only one is provided, not calling the extra marginalize_dist_stats_across_time layer

  • Please register or sign in to reply
  • Prathamesh Joshi
    Prathamesh Joshi @prathamesh.joshi started a thread on the diff
    • gstlal-inspiral/bin/gstlal_inspiral_workflow
    139 injections = DataCache.find(DataType.SPLIT_INJECTIONS, root=config.data.injection_dir, svd_bins="*", subtype="*")
    140 triggers += inj_triggers
    135 if config.rank.combine_rank:
    136 # aggregate the marg-dist-stat, trigger, and injection-trigger filenames over chunks for a combine rank
    137 dist_stats = DataCache(DataType.MARG_DIST_STATS)
    138 triggers = DataCache(DataType.TRIGGERS)
    139
    140 for filter_dir in config.data.filter_path: # FIXME: how to correctly input the directory from path
    141 dist_stats += DataCache.find(DataType.MARG_DIST_STATS, root=filter_dir, svd_bins="*")
    142 triggers += DataCache.find(DataType.TRIGGERS, root=filter_dir, svd_bins="*")
    143
    144 if config.injections.filter:
    145 injections = DataCache.find(DataType.SPLIT_INJECTIONS)
    146 for injection_dir in config.data.injection_path: # FIXME: how to correctly input the directory from path
    147 inj_triggers = DataCache.find(DataType.TRIGGERS, root=injection_dir, svd_bins="*", subtype="*")
    148 injections += DataCache.find(DataType.SPLIT_INJECTIONS, root=injection_dir, svd_bins="*", subtype="$
  • Prathamesh Joshi
    Prathamesh Joshi @prathamesh.joshi started a thread on the diff
    • gstlal-inspiral/python/dags/layers/inspiral.py
    436 436 return trigger_cache
    437 437
    438 438
    439 def aggregate_noise_layer(config, dag, marg_dist_stat_cache):
  • Prathamesh Joshi closed

    closed

    • Please register or sign in to reply