dtdphi: changes to allow dag to run end to end.

Also @surabhi.sachdev, potentially @alvin.li should look. These changes might make more sense if you consider the full diff relative to e30b5358 (the commit before first dtdphi proposed changes).

https://ldas-jobs.gwave.ics.psu.edu/~ryan.magee/dtdphi.patch

This is certainly not the only way to fix the issues I was having, but it is one way. I'd like this merged if everyone agrees it looks sensible, though at this point I'm tempted to open an issue to do some cleanup on these files and this code in general.

requested review from @leo.tsukada

assigned to @patrick.godwin

added 1 commit

• 5e41c3c4 - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs_dag: QOL change requested by alvin

Compare with previous version

I decided to store the psd and original SNRs in all h5 files, not just the one that describes the covariance matrix. The errors this patch fixes include:

Traceback (most recent call last): File "/ligo/software/ligo.org/ryan.magee/observing/3/builds/bankchisq-to-master-210728/opt/bin/gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs_dag", line 101, in <module> outputs = Argument("inspiral_dtdphi_pdf.h5", suppress=True) TypeError: __init__() missing 1 required positional argument: 'argument'

from making a dag

Traceback (most recent call last): File "/ligo/software/ligo.org/ryan.magee/observing/3/builds/bankchisq-to-master-210728/opt/bin/gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs", line 33, in <module> IE = inspiral_extrinsics.TimePhaseSNR.from_hdf5(fname = options.cov_mat_h5, verbose = True, margstart = options.start, margstop = options.stop) File "/ligo/software/ligo.org/ryan.magee/observing/3/builds/bankchisq-to-master-210728/opt/lib64/python3.6/site-packages/gstlal/stats/inspiral_extrinsics.py", line 1357, in from_hdf5 return cls(instruments = instruments, transtt = transtt, transtp = transtp, transpt = transpt, transpp = transpp, transdd = transdd, norm = norm, tree_data = tree_data, margsky = margsky, **kwargs) File "/ligo/software/ligo.org/ryan.magee/observing/3/builds/bankchisq-to-master-210728/opt/lib64/python3.6/site-packages/gstlal/stats/inspiral_extrinsics.py", line 1260, in __init__ self.tree_data = self.dtdphideffpoints(time, phase, deff, self.slices) File "/ligo/software/ligo.org/ryan.magee/observing/3/builds/bankchisq-to-master-210728/opt/lib64/python3.6/site-packages/gstlal/stats/inspiral_extrinsics.py", line 1462, in dtdphideffpoints outlen = len(time.values()[0]) TypeError: 'dict_values' object does not support indexing

from generating a singular dtdphisnr PDF

Traceback (most recent call last): File "/ligo/software/ligo.org/ryan.magee/observing/3/builds/bankchisq-to-master-210728/opt/bin/gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs", line 37, in <module> IE.to_hdf5(options.output) File "/ligo/software/ligo.org/ryan.magee/observing/3/builds/bankchisq-to-master-210728/opt/lib64/python3.6/site-packages/gstlal/stats/inspiral_extrinsics.py", line 1313, in to_hdf5 f.create_dataset("psd", data=self.psd_fname) File "/usr/lib64/python3.6/site-packages/h5py/_hl/group.py", line 106, in create_dataset dsid = dataset.make_new_dset(self, shape, dtype, data, **kwds) File "/usr/lib64/python3.6/site-packages/h5py/_hl/dataset.py", line 71, in make_new_dset raise TypeError("One of data, shape or dtype must be specified") TypeError: One of data, shape or dtype must be specified

from generating a singular dtdphisnr PDF

and also addresses various downstream incompatibilities at the DAG / adding stage introduced in my last MR.

added 13 commits

• 5e41c3c4...752a5f2a - 11 commits from branch master
• 45dfa0ba - dtdphi: changes to allow dag to run end to end.
• 7d745b0a - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs_dag: QOL change requested by alvin

Compare with previous version

added 4 commits

• 7d745b0a...16b022b7 - 2 commits from branch master
• a40979bb - dtdphi: changes to allow dag to run end to end.
• 217ff810 - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs_dag: QOL change requested by alvin

Compare with previous version

@cort.posnansky has one more change to add to this branch once he's made a developer.

@cort.posnansky, you should be added now.

Sorry for the delay. Ryan and I are trying to confirm that the output makes sense. We should have that done by tomorrow afternoon.

added 16 commits

• 217ff810...65d09a88 - 14 commits from branch master
• 98c8cae6 - dtdphi: changes to allow dag to run end to end.
• b9d231f3 - gstlal_inspiral_create_dt_dphi_snr_ratio_pdfs_dag: QOL change requested by alvin

Compare with previous version

closed

mentioned in merge request !77 (merged)