Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
L
lalsuite
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 109
    • Issues 109
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 30
    • Merge Requests 30
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • lscsoft
  • lalsuite
  • Issues
  • #376

Closed
Open
Opened Sep 02, 2020 by David Keitel@david-keitelDeveloper

lalapps_PredictFstat: make psi,Alpha,Delta optional?

@karl-wette since it's perfectly legal to use this code to estimate pure-noise 2F (trivial answer: 4) and h0,cosi,phi0 are already optional, I'm wondering why we don't do the same for the 3 remaining signal parameters.

Probably the original thinking in making them required was to guard users from thinking they're irrelevant and there's such a thing as the "true" predicted value for simply a (h0,cosi) pair without thinking about the other parameters; but to deal with that, we could still throw an error if h0>0 and any of the others are not set, like we already do with cosi.

Should be a straightforward MR, but I'd like to hear your opinion before doing it.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: lscsoft/lalsuite#376