LALSimInspiral seems to treat 'redshift' inconsistently
The LALSimInspiral param 'dictionary' includes 'redshift', which the documentation says is applied to the masses and distance. Some functions in LALSimInspiral.c do apply the (1+z) factors (and then set z=0 to prevent them being reapplied later) but it seems not all do. Specifically ..
SimInspiralTDModesFromPolarizations -> calls SimInspiralTD
SimInspiralTDFromTD -> applies 1+z factors, sets z=0, calls SimInspiralChooseTDWaveform
SimInspiralTDFromFD -> applies 1+z factors, sets z=0, calls SimInspiralFD
SimInspiralTD -> calls SimInspiralChooseTDWaveform
SimInspiralFD -> applies 1+z factors, sets z=0, calls SimInspiralChooseFDWaveform
ChooseTDWaveform -> doesn't do anything with z, calls SimInspiralTDFromFD for *most* native FD models but not all, otherwise no redshift is applied
ChooseFDWaveform -> doesn't do anything with z.
It seems a priori desirable to get the same behaviour for all waveform models and calling functions, so is that doable?