LALSimulation release request

Release details

Subpackage releases requested:

• lal
• lalframe
• lalmetaio
• lalsimulation
• lalburst
• lalinspiral
• lalinference
• lalpulsar
• lalapps

Commit information

The following commits should be included in the release:

• all commits since the last release of this subpackage
• only these commits:
  • e5048022
  • 5dec1651
  • dc6e05bb

@duncanmmacleod, @adam-mercer: We would like to request a release with these commits (which includes the recent MRs for PhenomXO4a, the new WF interface, a test fix for PhenomXPHM).

marked the checklist item only these commits: as completed

added lalinspiral lalsimulation release_request labels

assigned to @adam-mercer

The commits included also patch the build for lalinspiral (to accommodate the new waveform interface), so a new patch release of lalinspiral will be needed, but this shouldn't be complicated.

It looks like the changes for LALInspiral are:

diff --git a/lalinspiral/python/lalinspiral/Makefile.am b/lalinspiral/python/lalinspiral/Makefile.am
index fdd56f7d40..984271e4e7 100644
--- a/lalinspiral/python/lalinspiral/Makefile.am
+++ b/lalinspiral/python/lalinspiral/Makefile.am
@@ -32,7 +32,7 @@ pymodule_LTLIBRARIES = _thinca.la
 _thinca_la_SOURCES = _thinca.c
 _thinca_la_CPPFLAGS = $(AM_CPPFLAGS) $(SWIG_PYTHON_CPPFLAGS) -DMODULE_NAME="\"lalinspiral._thinca\""
 _thinca_la_CFLAGS = $(AM_CFLAGS) -fno-strict-aliasing -DMODULE_NAME="\"lalinspiral._thinca\""
-_thinca_la_LDFLAGS = $(AM_LDFLAGS) $(SWIG_PYTHON_LIBS) -module -avoid-version
+_thinca_la_LDFLAGS = $(AM_LDFLAGS) $(SWIG_PYTHON_LIBS) -module -avoid-version $(EXTRA_SWIG_PYTHON_LDFLAGS)
 
 thinca-all-local: _thinca.so

There are also changes for other libraries, changes to AUTHORS. There are a few ways this can be handled:

1. Backport the entire merge from f7925145 and release everything, with this only LALSimulation and LALInspiral will include functional changes.
2. Backport the entire merge but only release LALSimulation and LALInspiral, this will lead to the release branch being slightly different from what has been released.
3. Backport only the changes to LALSimulation and LALInspiral to the release branch.

I am currently leaning towards the third option, @duncanmmacleod with your Computing Chair hat on any thoughts?

@adam-mercer, with Option 2. is the AUTHORS information exposed in the binary packages?

Good point, it is not:

[root@b5c283ac6ae3 /]# rpm -ql lal | grep AUTHORS
[root@b5c283ac6ae3 /]# 

In that case I support Option 2.

Commits pushed to the release branch.

@karl-wette On the release branch the lint:authors job is currently failing, any ideas about this?

I'm concerned about just running the appropriate commands to update the AUTHORS files and committing the results as this could lead to issues backporting future changes.

@adam-mercer Cherry-picking !2138 (merged) should fix this.

Thanks a lot, that did the trick!

Releases have been tagged. Building the tarball nows.

Release has been made.

closed