Skip to content

Remove use of HDF5 hsize_t from lalinference

Duncan Macleod requested to merge duncanmmacleod/lalsuite:lalinference-no-hdf5 into master

Description

This merge removes the one and only use of HDF5's hsize_t in place of the standard size_t. Since that is the only HDF5 symbol used, and on 64-bit systems they are the same, this should represent no real change to the code.

This allows us to remove HDF5 as a direct dependency of lalinference, simplifying the build.

I also removed the HAVE_HDF5 logic, since I'm not convinced that you can actually build lal without HDF5 these days.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

Merge request reports