Skip to content

Update XLALPrecessingNRSurDynamics interface

Vijay Varma requested to merge waveforms/reviews/lalsuite:PrecessingSurDynamicsAPI into master

Description

Modification to the XLALPrecessingNRSurDynamics function for use with remnant fits.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

This function was added as part of MR !1041 (merged), but was not reviewed as it was not yet being used. These API changes are required for use with the remnant fits. This function has not been used anywhere so far, so this won't break anything.

Review Status

The changes will be reviewed as a part of the ongoing RemnantFits review (https://git.ligo.org/waveforms/reviews/RemnantFits/wikis/home) and MR !1074 (merged). I'm making the required API changes as part of a separate MR so that this can be included in the upcoming lalsimulation release and any future changes during the review should be backwards compatible.

Edited by Ghost User

Merge request reports