Updating XLALSimInspiralGetSpinFreqFromApproximant with SEOBNRv4P, SEOBNRv4PHM, and NRSur7dq4
requested to merge nathan-johnson-mcdaniel/lalsuite:XLALSimInspiralGetSpinFreqFromApproximant_update into master
Description
Adds the waveform models SEOBNRv4P, SEOBNRv4PHM, and NRSur7dq4 to the XLALSimInspiralGetSpinFreqFromApproximant function in LALSimInspiral.c, with SEOBNRv4P and SEOBNRv4PHM given as having their spins parameterized at flow (like the SEOBNRv3* waveforms) and NRSur7dq4 as having its spins parameterized at f_ref (like NRSur7dq2).
I have checked that my test script /home/nathan.johnson-mcdaniel/lalsim_spin_freq_coding/check_approx_enums_spinfreq_etc.py
on LHO passes with this change.
API Changes and Justification
Backwards Compatible Changes
-
This change introduces no API changes -
This change adds new API calls
Backwards Incompatible Changes
-
This change modifies an existing API -
This change removes an existing API
Review Status
Currently unreviewed