Skip to content

LALInferenceMCMC: Write injection params along with HDF5 to avoid over-writing chain file

John Douglas Veitch requested to merge john-veitch/lalsuite:inj_params_mcmc into master

Description

After resuming a past chain, MCMC would possibly over-write it with a new file containing the injection parameters but not the past chain. This could potentially prevent resume from working properly in some circumstances when running with an injection.

I think the bad code was left over from an earlier version, since the injection params table would not be written into the final file. This patch will fix that too by writing it along with the chain (in a different group).

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Ghost User

Merge request reports