Skip to content

lalapps_cbc_sbank_sim: fix bug with reading polarization; lalapps_cbc_sbank_sim_pipe: loop through all injections

Rebecca Ewing requested to merge rebecca.ewing/lalsuite:master into master

Description

These changes are required to fix bugs in lalapps_cbc_sbank_sim and lalapps_cbc_sbank_sim_pipe programs. Currently the lalapps_cbc_sbank_sim_pipe (dag generator) has a bug that prevents the bank sim code to loop through all the injections. The lalapps_cbc_sbank_sim program has a bug where it randomly generates polarization values instead of reading them through the injection file so there is no reproducibility of results.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Ghost User

Merge request reports