Skip to content

Add IMRPhenomXAS and IMRPhenomXHM reviewed models

Cecilio Garcia-Quiros requested to merge waveforms/reviews/lalsuite:imrphenomx-review into master

Description

Add two new CBC non-precessing models: IMRPhenomXAS (22 mode only) and IMRPhenomXHM (including higher harmonics). Waveform review is already passed (see links to sign off presentation below). @harald.pfeiffer, @sebastian-khan, please approve if you agree with this to be merged.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Waveform review signed off by @maria.haney. Review wiki link: https://git.ligo.org/waveforms/reviews/imrphenomx/-/wikis/home#review-statement Presentation slides review signoff (wavefom call 30 January 2020): https://dcc.ligo.org/G2000156

Edited by Ghost User

Merge request reports