Skip to content

Adding PhenomPv3HM

Sebastian Khan requested to merge waveforms/reviews/lalsuite:phenompv3hm-review into master

This MR adds the models IMRPhenomPv3 and IMRPhenomPv3HM to lalsimulation

These models have been reviewed and the review statement can be found here:

https://git.ligo.org/waveforms/reviews/phenompv3hm/-/wikis/home#review-statement

This MR modifies some of the source code for PhenomD, PhenomHM and PhenomPv2 however the review has verified (through the use of regression tests) that there is no difference in the output for these waveforms. The results of the regression tests can be found here: https://git.ligo.org/waveforms/reviews/phenompv3hm/-/wikis/regression-tests

The commits will be squashed when the MR is accepted.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Edited by Ghost User

Merge request reports