Skip to content

Update .mailmap, add test to make sure AUTHORS is correctly formatted

Karl Wette requested to merge (removed):update-check-author-lists into master

Description

This MR related to the code that builds the AUTHORS lists of authors of each LAL library. It:

  1. Adds .AUTHORS to the GitLab CODEOWNERS, so changes require approval from @adam-mercer and @karl-wette. (Generally this file should not be changed anyway.)
  2. Updates .mailmap to fix a few incorrectly-formatted names in AUTHORS.
  3. Adds a make check that AUTHORS is correctly formatted, i.e. it contains nicely formatted human names like Albert Einstein as opposed to computer usernames like albert.einstein. This will mean that CI builds will fail if someone hasn't correctly set up their Git configuration to use a proper human name. Catching these occasional problems early means that I won't have the responsibility for periodically updating the .mailmap entries.

We might also want to consider switching on the Committer restriction setting under Repository / Push Rules, which would mean that "users can only push commits to this repository that were committed with one of their own verified emails", which may also help prompt users to correctly set up their Git configuration. It's possible that might have other consequences, however.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

@adam-mercer to review.

Merge request reports