Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
L
lalsuite
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 113
    • Issues 113
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 33
    • Merge Requests 33
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • lalsuite
  • Merge Requests
  • !1214

Closed
Created Feb 07, 2020 by David Keitel@david-keitelDeveloper1 of 4 tasks completed1/4 tasks
  • Report abuse
Report abuse

Resolve "lalinference.imrtgr.imrtgrutils.calc_final_mass_spin failing on master"

  • Overview 8
  • Commits 1
  • Pipelines 1
  • Changes 1

Description

This should fix #262 (closed) where bbh_average_fits_precessing() fails when called with scalar inputs. All the lower-level fit functions called by this wrapper through _return_quantity() already do proper vectorizing, so the single sanity check line that is changed in this MR should be the only bit that needs a fix.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

@nathan-johnson-mcdaniel can review

Closes #262 (closed)

Edited Feb 07, 2020 by David Keitel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix-262-lalinference-imrtgr-imrtgrutils-calc_final_mass_spin-failing-on-master