Change the behaviour of XLALSimInspiralFD for precessing EOB

Description

This introduces changes to XLALSimInspiralFD only for time domain precessing EOB models: SEOBNRv3, SEOBNRv3_opt, SEOBNRv4P, SEOBNRv4PHM Essentially, the initial frequency is no longer modified internally by this function, which is the correct behaviour for these models.

API Changes and Justification

Backwards Compatible Changes

• This change introduces no API changes
• This change adds new API calls

Backwards Incompatible Changes

• This change modifies an existing API
• This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

lalsimulation/lib/LALSimInspiral.c

@@ -2228,7 +2228,9 @@ static int XLALSimInspiralTDFromFD(
  * the very end of the waveform are also tapered.  The resulting waveform is high-pass
  * filtered at frequency f_min so that it should have little content at lower frequencies.
 
- * If calling the NR_hdf5 approximant then the starting frequency is not altered.
+ * If calling the NR_hdf5 approximant then the starting frequency is not altered. This is also
+ * the case if calling any of the time-domain, precessing EOB approximants:
+ * [SEOBNRv3,SEOBNRv3_opt,SEOBNRv4P,SEOBNRv4PHM]
  *
  * This routine used to have one additional parameter relative to XLALSimInspiralChooseTDWaveform:
  * the redshift, z, of the waveform, which is now stuffed into the LALDict structure.
@@ -2274,7 +2276,7 @@ int XLALSimInspiralTD(
         * This is because XLALSimInspiralTDFromTD modifies the start frequency
         * which is not always possible with NR_hdf5 waveforms.
         */
-        if (approximant == NR_hdf5)
+        if (approximant == NR_hdf5 || approximant == SEOBNRv3 || approximant == SEOBNRv3_opt || approximant == SEOBNRv4P || approximant == SEOBNRv4PHM)
         {
             if (XLALSimInspiralChooseTDWaveform(hplus, hcross, m1, m2, S1x, S1y, S1z, S2x, S2y, S2z, distance, inclination, phiRef, longAscNodes, eccentricity, meanPerAno, deltaT, f_min, f_ref, LALparams, approximant) <0)
                 XLAL_ERROR(XLAL_EFUNC);