Skip to content

Fix ligo-skymap-plot call in LALInference pipeline

John Douglas Veitch requested to merge john-veitch/lalsuite:fix_plotskymap into master

Description

Fix error in LALInference DAG generator that produces DAG files containing entries like

VARS 223bea396fd58ce73be136ddf5a138f4 macrooutput="../../../../../../public_html/LVC/projects/O3/C01/XXXX/skymap.png,/home/daniel.williams/public_html/LVC/projects/O3/C01/XXXX/skymap.png" macroinput="../../../../../../public_html/LVC/projects/O3/C01/XXXX/LALInference.fits" macroargument0="/home/daniel.williams/public_html/LVC/projects/O3/C01/XXXX/LALInference.fits"

here the macrooutput contains two copies of the filename, because of a problem with the way the LALInferenceDAGNode class over-rides the pipeline.CondorDAGNode. This is only a problem when the executable has an option called "output". An alternative solution would be to not inherit from the LALInferenceDAGNode class, but I thought this was a lesser change.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports