Skip to content

.gitattributes: add wildcard for all files lalapps/src/pulsar/*/test*.tar.gz

Karl Wette requested to merge (removed):gitattributes-wildcard-lalapps-pulsar into master

Description

A consequence of the new framework for tests of CW codes in LALApps (!1206 (merged)) is that all files that the test needs from the source directory (e.g. a reference file to compare code output against) must be included in a tarball named after the test script. As a result, there are a number of files named lalapps/src/pulsar/*/test*.tar.gz, and are likely to be more as we add more tests.

Since these files could potentially be quite large (at the moment the largest is ~6 MB) I think it would be good to have them tracked by git lfs by default. Rather than having to remember to manually git lfs track each file, it would be easier to have a wildcard for all files lalapps/src/pulsar/*/test*.tar.gz in .gitattributes. This wildcard is specific enough to only pick up the reference tarballs for CW test scripts. This would also avoid merge conflicts where different MRs both modify .gitattributes at once.

I think it's okay to have wildcards in .gitattributes, as that file is actually handled by Git itself, not Git LFS, so it should be robust.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

@adam-mercer Any concerns?

Merge request reports