Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
L
lalsuite
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 105
    • Issues 105
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 26
    • Merge Requests 26
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • lscsoft
  • lalsuite
  • Merge Requests
  • !1228

Merged
Opened Feb 15, 2020 by Salvatore Vitale@salvatore-vitaleDeveloper

Fix a couple of bugs in lalinference modeList input

  • Overview 9
  • Commits 2
  • Pipelines 2
  • Changes 1

see !1101 (comment 150414)

The code was using strtok_r passing ppt=LALInferenceGetProcParamVal(commandLine,"--modeList") as first argument. However strtok_r modifies the first argument in place...

Since MCMC is multithreaded, initCBC is being called multiple times, but the first caller would modify the argument of --modeList in place, terminating it after the first set of l,m, which means the other callers would only get only one l,m added to their LALSim structure.

MCMC results produce with this code are thus to be discarded. Only one chain will have the correct (l,m)'s (maybe) while the others will for sure be wrong and only have whatever mode happened to be first in --ModeList [...]

I also added a few comments and improved the variable naming style.

Assignee
Assign to
Reviewer
Request review from
O3 Point Release
Milestone
O3 Point Release
Assign milestone
Time tracking
Reference: lscsoft/lalsuite!1228
Source branch: fix_modes

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.