Skip to content

XLALOutputVersionString: use XLALVCSInfoString instead of XLALGetVersionString

David Keitel requested to merge david-keitel/lalsuite:XLALOutputVersionString-update into master

Description

This fixes a deprecation warning

DEPRECATION WARNING: program has invoked obsolete function XLALGetVersionString(). Please see XLALVCSInfoString() for information about a replacement.

I noticed from lalapps_ComputePSD. See below for other caller codes (including pulsar inspiral, ring and hwinjection).

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@karl-wette the following files call this function:

lalapps/src/inspiral/blindinj.c
lalapps/src/inspiral/calcexpsnr.c
lalapps/src/ring/coh_PTF_option.c
lalapps/src/pulsar/Tools/ComputeAntennaPattern.c
lalapps/src/pulsar/SFTTools/ComputePSD.c
lalapps/src/inspiral/fr_ninja.c
lalapps/src/inspiral/inspfrinj.c
lalapps/src/inspiral/inspinj.c
lalapps/src/hwinjection/psinject.c
lalapps/src/inspiral/splitbank.c
lalapps/src/inspiral/tmpltbank.c
lalapps/src/inspiral/trigscan.c

Lots of non-CW ones among them, so not sure if we need extra approval, though it is a fairly trivial update.

Merge request reports