Skip to content

Modification to ChooseTDModes

Roberto Cotesta requested to merge roberto.cotesta/lalsuite:ChooseTDModes into master

Description

This patch is reverting a change to ChooseTDModes that was not taking anymore phiRef as an argument. Now phiRef is again an argument of the function but it is not used internally.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

In a previous commit the argument phiRef was removed from ChooseTDModes. This created incompatibilities with some parameter estimation codes (i.e. RIFT). We decided to undo the change. The argument phiRef is not used (it wasn't used before the change either) and the user gets a warning that the argument is not used and that it will be removed in the future.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Ghost User

Merge request reports